Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failover configuration #760

Closed
wants to merge 10 commits into from
Closed

Failover configuration #760

wants to merge 10 commits into from

Conversation

volovyks
Copy link
Collaborator

Closing #733

  • Added support for multiple API Keys (since we can have multiple RPC Servers)
  • Added basic failover functionality

With this design of failover, we will change (rotate) our server when needed and stick to this new server for our next calls. It will help to avoid long responses when first (or more) servers are down.

For now, server rotation is happening only on Timeout error.

Also, check this comment: #733 (comment)

@volovyks volovyks requested a review from vgrichina as a code owner December 23, 2021 17:32
@volovyks volovyks self-assigned this Dec 23, 2021
@volovyks volovyks linked an issue Dec 23, 2021 that may be closed by this pull request
RPC Redundancy/Failover Configuration #733
Closed
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Dec 31, 2021
@volovyks volovyks removed the Stale label Jan 4, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Jan 13, 2022
ailisp
ailisp reviewed Jan 13, 2022
View reviewed changes
lib/near.d.ts
/**
* RPC API Keys. Used to authenticate users on RPC Server.
*/
apiKeys: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be string[] as well when nodeUrl is string[]?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I think it's good. The use case is for fallback, should have same apiKey

ailisp
ailisp approved these changes Jan 13, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TrevorJTClarke
Copy link
Contributor

Is this PR ready? This allows failover logic with config for multiple RPC providers?

@github-actions github-actions bot removed the Stale label Jan 15, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Jan 23, 2022
@ailisp ailisp removed the Stale label Jan 24, 2022
@TrevorJTClarke
Copy link
Contributor

Any updates?

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2022

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Feb 1, 2022
@github-actions github-actions bot added the Stale label Mar 19, 2022
@ailisp
Copy link
Member

ailisp commented Mar 21, 2022

@MaximusHaximus ptal :)

@ailisp ailisp removed the Stale label Mar 21, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Mar 28, 2022
@ailisp ailisp removed the Stale label Mar 28, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Apr 12, 2022
@ailisp ailisp removed the Stale label Apr 13, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label Apr 27, 2022
@idea404 idea404 removed the Stale label Apr 27, 2022
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@github-actions github-actions bot added the Stale label May 12, 2022
@github-actions github-actions bot closed this May 19, 2022
@volovyks volovyks reopened this May 19, 2022
@github-actions github-actions bot closed this May 27, 2022
@volovyks volovyks reopened this May 27, 2022
@github-actions github-actions bot closed this Jun 4, 2022
@volovyks volovyks reopened this Jun 6, 2022
MrPiNkY2022
MrPiNkY2022 approved these changes Sep 12, 2022
View reviewed changes
Copy link

@MrPiNkY2022 MrPiNkY2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge

@waynenilsen
Copy link

we need fallback also

@gtsonevv
Copy link
Collaborator

gtsonevv commented Dec 6, 2023

Hey @frol, do you want this PR to be merged? If so, we suggest closing the existing PR and moving all the changes to a new one. It will be much easier for us to resolve the conflicts that way. What do you think?

@frol
Copy link
Collaborator

frol commented Dec 6, 2023

It will be much easier for us to resolve the conflicts that way. What do you think?

Sure, makes sense. I would keep this PR open until a new one is submitted, so we don't lose track of it.

This was referenced Dec 7, 2023
Closed
Closed
@denbite denbite mentioned this pull request Apr 8, 2024
Merged
5 tasks
@vikinatora
Copy link
Collaborator

This functionality has been merged with #1334

@vikinatora vikinatora closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrPiNkY2022 MrPiNkY2022 MrPiNkY2022 approved these changes

@ailisp ailisp ailisp approved these changes

@MaximusHaximus MaximusHaximus Awaiting requested review from MaximusHaximus

@vgrichina vgrichina Awaiting requested review from vgrichina

Assignees

@volovyks volovyks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC Redundancy/Failover Configuration